Skip to content

Generate Speech to Text#335

Merged
germanattanasio merged 9 commits intonextfrom
generate-speech-to-text
Feb 13, 2018
Merged

Generate Speech to Text#335
germanattanasio merged 9 commits intonextfrom
generate-speech-to-text

Conversation

@ammardodin
Copy link
Copy Markdown
Contributor

@ammardodin ammardodin commented Dec 15, 2017 •
edited by ehdsouza
Loading

  • Generated Speech to Text from latest Swagger.
  • Manual tweaks to add_word and add_words
  • Update old tests to use new signatures
  • Add tests for acoustic customizations, recognitions, callbacks, custom audio resources
  • Add integration tests

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 15, 2017 •
edited
Loading

Codecov Report

Merging #335 into next will decrease coverage by 1.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #335      +/-   ##
=========================================
- Coverage   38.21%     37%   -1.22%     
=========================================
  Files          25      25              
  Lines        9141   10370    +1229     
=========================================
+ Hits         3493    3837     +344     
- Misses       5648    6533     +885
Impacted Files Coverage Δ
watson_developer_cloud/speech_to_text_v1.py 32.85% <ø> (-67.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad44aac...8f4fdba. Read the comment docs.

@germanattanasio germanattanasio changed the base branch from master to next February 7, 2018 18:07
mkistler
mkistler approved these changes Feb 8, 2018
View reviewed changes
Copy link
Copy Markdown

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge into "next", since it has breaking changes. 👍

@germanattanasio germanattanasio requested review from germanattanasio and removed request for germanattanasio February 13, 2018 02:10
@germanattanasio
Copy link
Copy Markdown
Contributor

germanattanasio commented Feb 13, 2018 •
edited
Loading

Some of the methods require a content-type even that they only support application/json. The method should use application/json without having to ask the user for content-type

@germanattanasio germanattanasio requested review from mamoonraja and removed request for germanattanasio and mamoonraja February 13, 2018 22:01
@germanattanasio germanattanasio merged commit 85e8231 into next Feb 13, 2018
@germanattanasio germanattanasio deleted the generate-speech-to-text branch February 14, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mkistler mkistler mkistler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ammardodin @codecov-io @germanattanasio @mkistler @ehdsouza